Add markdown embed support for wikilinks #1207
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return Entry.get(blogID, linkedPath, function (err, entry) { | ||
| if (err) { | ||
| debug("Error fetching entry for embedded markdown", err); | ||
| return next(); | ||
| } |
There was a problem hiding this comment.
When embedding markdown media, Entry.get is called with an (err, entry) callback, but Entry.get (app/models/entry/get.js:9-50) passes the entry as the first and only argument and throws on errors. As a result the entry object is treated as err, the error check fires, and the branch returns before replacing the node or adding dependencies, so markdown wikilink embeds never render. Adjust the callback to match the actual signature so markdown embeds are processed.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.