Adding comments column ( Feature Request #6 )#7
Open
BlackthornYugen wants to merge 4 commits intodavidc:masterfrom
Open
Adding comments column ( Feature Request #6 )#7BlackthornYugen wants to merge 4 commits intodavidc:masterfrom
BlackthornYugen wants to merge 4 commits intodavidc:masterfrom
Conversation
+ Added ability to add comments. Adding a comment disables join/divide for that network. Adjusted colours on joins that cannot be clicked. + Fixed CSS bug so hand cursor is shown as intended over maskSpanJoinable elements.
BlackthornYugen
commented
May 3, 2021
BlackthornYugen
force-pushed
the
feature/comments
branch
from
daca46d to
012f394
Compare
Don't break old links, use comments only if provided.
BlackthornYugen
force-pushed
the
feature/comments
branch
from
012f394 to
3c3908d
Compare
+ Escape chars for links + Don't assume subnets.html
Contributor
Author
|
But a link without comments still works |
Contributor
Author
|
Textarea still adds a fair bit to each row's height that might bother existing users. Maybe I should add my fix for toggle columns and have comments hidden by default? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to add comments. Adding a comment disables join/divide
for that network. Adjusted colours on joins that cannot be clicked.
Fixed CSS bug so hand cursor is shown as intended over
maskSpanJoinable elements.