Updates to styles, removed bits that didn't work, increased readability/usability#1
Open
jcostom wants to merge 8 commits intodavidc:masterfrom
Open
Updates to styles, removed bits that didn't work, increased readability/usability#1jcostom wants to merge 8 commits intodavidc:masterfrom
jcostom wants to merge 8 commits intodavidc:masterfrom
Conversation
* Change from GIF to PNG (unencumbered image formats are better) * Modularized - Moved CSS and JS to their own files
* Got rid of table at top of page, changed for <div> * Intro Google Fonts * Lato for most * Source Code Pro for addresses * Overall beautify
Signed-off-by: Jason Costomiris <jcostom@jasons.org>
|
Been loving this tool of late. Would be awesome if the output could be exported to excel/spreadsheet format for further editing. But other than that, this tool has helped me immensely. |
Large numbers of hosts (/0 and /1 subnets) are overflowing and showing as a negative number. Changing 1<<(32-mask) to 2**(32-mask) causes JavaScript to calculate the integer properly.
Change shift left operator to exponent operator to avoid overflow
Fixed in #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hey -
Seriously great tool here. I've made some improvements on it (I hope)...
I hope you're willing to accept my proposals! Thanks for creating a nice tool.