Fix ctypes argument error in setProsodyParam #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apparently sends the wrong type sometimes and this causes the entire thread to hang because of a ctypes exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when using the earcons and speech rules add-on in browsers, somehow a prosody parameter of some type other than int makes it to the driver. When this happens, since ctypes refuses to coerce a float to an int by itself, an exception is thrown. This causes NVDA to completely hang when the exception is thrown and all synth threads are locked up.
This PR fixes this hang by simply wrapping the
vlargument in a call toint()when passing todll.eciSetVoiceParam.Note that, while this makes the earcons and speech rules add-on technically usable with this driver, there is still the matter of indexing, which is a separate issue to be solved. Whether that's via #96 or some other approach, depending on WASAPI, is up to you, but it should be done at some point soon.