CNDB-15157: limit log lines during commitlog replay #2001
Conversation
Checklist before you submit for review
|
| if (skippedSSTables.size() <= maxSSTablesToLog) { | ||
| logger.debug("Ignored commitLogIntervals from the following sstables: {}", skippedSSTables); | ||
| } else { | ||
| List<String> sample = new ArrayList<>(skippedSSTables).subList(0, maxSSTablesToLog); |
There was a problem hiding this comment.
nit:
if the number of sstables is very big this is going to create a big ArrayList, maybe we can do it the same way you did in "construct": iterate and keep the first N
|
I thought about that too and came to the same conclusion. |
| // Limit the number of SSTable names logged to prevent massive log lines | ||
| int maxSSTablesToLog = 100; | ||
| if (skippedSSTables.size() <= maxSSTablesToLog) { | ||
| logger.debug("Ignored commitLogIntervals from the following sstables: {}", skippedSSTables); |
There was a problem hiding this comment.
I was wondering: Do we always hit this in CNDB replayer? If yes, is there a way we can turn the log off if it's not useful?
There was a problem hiding this comment.
If we don't want them just in CNDB, we should be able to suppress them with logback. If you'd prefer that I can do it in a different PR.
There was a problem hiding this comment.
actually I think we'd have to suppress all the logs from CommitLogReplayer if we do it though logback.
|
✔️ Build ds-cassandra-pr-gate/PR-2001 approved by ButlerApproved by Butler |
What is the issue
Very long log lines can be produced during commitlog replay
What does this PR fix and why was it fixed
Limits the amount of information printed at debug, but retains full information at trace