Skip to content

CNDB-14657: disable synthetic score for older versions in FeaturesVersionSupportTester #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

CNDB-14657: disable synthetic score for older versions in FeaturesVersionSupportTester #1988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...uted/org/apache/cassandra/distributed/test/sai/features/FeaturesVersionSupportTester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,16 @@ protected static void initCluster(Version version) throws IOException

FeaturesVersionSupportTester.version = version;
cluster = init(Cluster.build(2)
.withInstanceInitializer((cl, n) -> BB.install(cl, n, version))
.withInstanceInitializer((cl, n) -> {
// Disable synthetic score to ensure compatibility between ED and older versions.
// ED enables it by default but older versions don't support it.
// Note: In 5.0, Ordering.useSyntheticScore() uses CassandraRelevantProperties
// which caches values at class loading time, so we must set this property before
// the classes are loaded. In the main branch, Ordering uses System.getProperty() directly,
// which is why this workaround isn't needed there.
System.setProperty("cassandra.sai.ann_use_synthetic_score", "false");
BB.install(cl, n, version);
})
.withConfig(config -> config.with(GOSSIP).with(NETWORK))
.start(), 1);

Expand Down