Skip to content

Erase all PK-based filtering structures#148

Merged
toptobes merged 2 commits intomainfrom
SL-erase-all-pk-filtering-test
Apr 17, 2026
Merged

Erase all PK-based filtering structures#148
toptobes merged 2 commits intomainfrom
SL-erase-all-pk-filtering-test

Conversation

@sl-at-ibm
Copy link
Copy Markdown
Collaborator

@sl-at-ibm sl-at-ibm commented Apr 16, 2026

Bringing further the motion with making table filtering uniform (= no matter what the role of the column in the table schema), this PR evolves #143 -- supplanting it if accepted -- and entirely removes the following from filter builders:

  • PrimaryKeyFilter
  • CompoundKey
  • CompositeKey

This is only for filtering. The rationale is that:

  1. users can treat all columns the same way when it comes to constructing filters, e.g. Builders<RowClass>.TableFilter.Eq(...) and this is not a problem, (functionally) resulting in the same payload to the API
  2. more aligned with the other clients, and the doc structure / cross-language learning journey for the user also benefits
  3. Structures that enforce the PK/schema structure of a table would be more useful, except (a) the specific Cassandra constraints on PK-based filtering are far from trivial and not easily captured in a compile-time-enforced way; and (b) which columns you can and which you can't filter on, ultimately also depends on the table indexes (and hence even more out of control from this perspective).

Note: this PR replaces #143 if merged (so, let's make sure to close that one if this is accepted).

Closes #75

@sl-at-ibm sl-at-ibm requested a review from toptobes April 16, 2026 20:41
@sl-at-ibm sl-at-ibm force-pushed the SL-erase-all-pk-filtering-test branch from ced639d to fae69d8 Compare April 16, 2026 20:42
@toptobes toptobes added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 7968995 Apr 17, 2026
7 checks passed
@toptobes toptobes deleted the SL-erase-all-pk-filtering-test branch April 17, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relation between TableFilterBuilder, FilterBuilder and PrimaryKeyFilter ?

3 participants