A tiny test fix (about NANfinities in collections)#145
Merged
Conversation
toptobes
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sure this is what was meant to be tested (no big deal)
Now a real question. Inspecting the payload shows that the original insertion is serialized as:
This is identical, in effect, to writing a literal
+rather than its escape, but I do wonder: how come the plus sign, and only the plus sign, is escaped? It's not a high-value obscure unicode sequence or something, no?(this may hint at something potentially troublesome in the serdes machinery? Probably not...)
(also it sounds like a (tiny) waste of bytes. Oh, well).