Subsume waitForCompletion/updateDBKeyspace into BlockingCommandOptions#134
Merged
Subsume waitForCompletion/updateDBKeyspace into BlockingCommandOptions#134
Conversation
Collaborator
Author
|
@a-random-steve FYI |
e16432a to
388a464
Compare
Collaborator
Author
|
Note for posterity. Considering the fact that you can anonymously instantiate in the argument (i.e. |
Collaborator
Author
|
And here we go with the @skedwards88 breaking change. Please note that the "HCD create-and-use" pattern remains short, as exemplified in |
toptobes
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127 .
More specifically, this PR solves the issue of multiple/opaque bool params to
{Create/Drop} x {Database/Keyspace}.BlockingCommandOptionsofCommandOptions, used in those methodswaitForCompletionboolean (defaulting to true)DropDatabaseis not aboolanymore, rather a void, as its semantics would (also DropKeyspace and other clients work like that) (slight) breaking change[the following part outdated, see further posts]
Now I did not subsumeupdateDbKeyspaceinto these options... yet. I am not 100% sure this should be done at all:it's only one boolean (still 'opaque', but just one)Its meaning is not really that of "an option that controls request execution" to be strict (like the rest of BlockingCommandOptions is)keeping it top-level saves the quick, easy HCD one-liner "create keyspace and have the DB set to use it". Otherwise it would get a tad more verbose.@toptobes any opinion?