Skip to content

[RAPTOR-14025] Allow override nim server details, release v1.16.10.1 #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

yakov-g
Copy link
Collaborator

@yakov-g yakov-g commented Jun 25, 2025

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Summary

We need to override health route for NVidia nim

Rationale

@yakov-g yakov-g force-pushed the yakov/drum-actual-fix branch 3 times, most recently from eae4eb7 to 287c246 Compare June 25, 2025 23:52
@devexp-slackbot
Copy link

EngProd failed to find the label for the "@datarobot/custom-models" code owner.

Make sure that the following is true:

  • The GitHub team is correct in the code owners file (CODEOWNERS or DRCODEOWNERS);
  • The Review Group you are looking for is present in the constants.py file.

How to add a new Review Group

Review group should be added in the constants.py file. Scroll down until you will find the REVIEW_GROUPS list. Check master branch for the most recent examples.

Example PR: #3442

Where to find domain id?

To leverage all EngProd features, domain ID should be specified. In order to find it - navigate to the People DB Domains portal and find your domain there.

After clicking on the domain - domain ID should appear in the URL field like here:

domain_id_hint

Copy it to your review group and you're all set with the domain id.


If everything is correct but the functionality still does not work - please check with the #engprod team in Slack.

@engprod-2
Copy link

engprod-2 bot commented Jun 26, 2025

The Needs Review labels were added based on the following file changes.

Team @datarobot/core-modeling (#predictive-ai) was assigned because of changes in files:

custom_model_runner/CHANGELOG.md
custom_model_runner/datarobot_drum/drum/description.py

Team @datarobot/custom-models was assigned because of changes in files:

custom_model_runner/CHANGELOG.md
custom_model_runner/datarobot_drum/drum/description.py
custom_model_runner/datarobot_drum/drum/gpu_predictors/base.py
custom_model_runner/datarobot_drum/drum/gpu_predictors/nim_predictor.py
tests/unit/datarobot_drum/drum/gpu_predictors/test_gpu_predictors.py

Team @datarobot/tracking-agent (#tracking-agent-reviews) was assigned because of changes in files:

custom_model_runner/datarobot_drum/drum/gpu_predictors/base.py
custom_model_runner/datarobot_drum/drum/gpu_predictors/nim_predictor.py

If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file.

@yakov-g
Copy link
Collaborator Author

yakov-g commented Jun 26, 2025

Added simple unittests

@yakov-g yakov-g merged commit 1e7a035 into drum_release/v1.16.10 Jun 26, 2025
5 of 7 checks passed
@svc-engprod-git1 svc-engprod-git1 deleted the yakov/drum-actual-fix branch June 26, 2025 16:42
yakov-g pushed a commit that referenced this pull request Jun 26, 2025
…1539)

Co-authored-by: Bogdan Klichuk <bogdan.klichuk@datarobot.com>
yakov-g pushed a commit that referenced this pull request Jun 26, 2025
…1539)

Co-authored-by: Bogdan Klichuk <bogdan.klichuk@datarobot.com>
yakov-g pushed a commit that referenced this pull request Jun 26, 2025
…1539)

Co-authored-by: Bogdan Klichuk <bogdan.klichuk@datarobot.com>
yakov-g pushed a commit that referenced this pull request Jun 26, 2025
…1539)

Co-authored-by: Bogdan Klichuk <bogdan.klichuk@datarobot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants