[RAPTOR-12499] SemGrep detected `root` user in dronin environments #1423

peterzdeb · 2025-05-12T13:10:24Z

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Summary

All the reported images were updated with non-root user. For Changuard images we have nonroot and nobody for other Debian-type images.

Rationale

SemGrep security scanner is configured for all DataRobot repositories.
For the environment images with DRUM it reports two issues:

last-user-is-root: The last user in the container is root. This is a security hazard because if an attacker gains control of the container they will have root access. Switch back to another user after running commands as root.
missing-user-entrypoint: By not specifying a USER, a program in the container may run as root. This is a security hazard. If an attacker can control a process running as root, they may have control over the container. Ensure that the last USER in a Dockerfile is a USER other than root.

devexp-slackbot · 2025-05-13T11:50:17Z

The Needs Review labels were added based on the following file changes.

Team @datarobot/buzok (#buzok) was assigned because of changes in files:

public_dropin_environments/python311_genai/Dockerfile

Team @datarobot/codegen (#scoring-code) was assigned because of changes in files:

public_dropin_environments/python311_genai/Dockerfile

Team @datarobot/core-modeling (#predictive-ai) was assigned because of changes in files:

custom_model_runner/CHANGELOG.md
public_dropin_environments/python3_keras/Dockerfile
public_dropin_environments/python3_pmml/Dockerfile
public_dropin_environments/python3_pytorch/Dockerfile
public_dropin_environments/python3_sklearn/Dockerfile
public_dropin_environments/python3_xgboost/Dockerfile
public_dropin_environments/r_lang/Dockerfile

Team @datarobot/custom-models (#custom-models) was assigned because of changes in files:

custom_model_runner/CHANGELOG.md
example_dropin_environments/julia_mlj/Dockerfile
example_dropin_environments/python311_genai-gpu/Dockerfile
example_dropin_environments/python39_genai/Dockerfile
public_dropin_environments/java_codegen/Dockerfile
public_dropin_environments/python311/Dockerfile
public_dropin_environments/python3_keras/Dockerfile
public_dropin_environments/python3_onnx/Dockerfile
public_dropin_environments/python3_pmml/Dockerfile
public_dropin_environments/python3_pytorch/Dockerfile
public_dropin_environments/python3_sklearn/Dockerfile
public_dropin_environments/python3_xgboost/Dockerfile
public_dropin_environments/r_lang/Dockerfile
public_dropin_environments_sandbox/fips_python3_keras/Dockerfile
public_dropin_environments_sandbox/python3_keras/Dockerfile
public_dropin_nim_environments/nim_sidecar/Dockerfile

Team @datarobot/tracking-agent (#tracking-agent-reviews) was assigned because of changes in files:

public_dropin_nim_environments/nim_sidecar/Dockerfile

If you think that there are some issues with ownership, please discuss with C&A domain at #sdtk slack channel and create PR to update DRCODEOWNERS\CODEOWNERS file.

peterzdeb · 2025-05-13T11:52:03Z

public_dropin_environments/java_codegen/Dockerfile

-
-RUN sh -c "python -m venv ${VIRTUAL_ENV} && \
-    . ${VIRTUAL_ENV}/bin/activate && \
-    python -m ensurepip --default-pip && \
-    python -m pip install --upgrade pip && \
-    python -m pip install --no-cache-dir -r requirements.txt && \
-    find ${VIRTUAL_ENV} -type d -name '__pycache__' -exec rm -rf {} + && \
-    rm -rf /usr/bin/rm /usr/bin/find"


All that commands do not need a separate shell when building Docker image. I moved the dependencies installation step into build stage.

peterzdeb · 2025-05-13T11:52:49Z

public_dropin_environments/java_codegen/Dockerfile

-COPY --from=build /usr/bin/rm /usr/bin/rm
-COPY --from=build /usr/bin/find /usr/bin/find


No cleanup needed as we remove __pycache__ in the build stage. The rm and find commands won't be needed in the runtime image

peterzdeb · 2025-05-13T11:53:38Z

public_dropin_environments/r_lang/Dockerfile

-    python ensure_sh_shebang.py ${R_HOME}/bin && \
-    mkdir -p /usr/share/doc/R/html && \


Moved these two lines into a separate steps in the Dockerfile.

shopin32

LGTM. I think we do not own those anymore

datarobot-user-models/DRCODEOWNERS

Lines 35 to 36 in e6db861

    
           /public_dropin_environments/python311_genai                       @datarobot/buzok @datarobot/codegen 
        
           /public_dropin_environments/python311_genai_agents                @datarobot/buzok @datarobot/codegen

, custom-model is now in charge.

tsdaemon

LGTM Buzok

klichukb · 2025-05-14T10:09:29Z

example_dropin_environments/julia_mlj/Dockerfile

@@ -24,4 +24,6 @@ ENV WITH_ERROR_SERVER=1
 #Uncomment the following line to switch to production mode
 #ENV PRODUCTION=1 MAX_WORKERS=4 SHOW_STACKTRACE=1

+USER nobody


This might not matter too much. In LRS we run the container with a specific set of user id / group id (defaults are 1000:1000), also we force chown on the /opt/code to these.
I'm not sure if setting USER to something else would do it.

can you test building such image and testing on staging and/or locally?

not sure I can test this on staging before merging the PR. Will try

@klichukb I tested this image on Staging. It really lacks permissions if running for any non-root user (when tried to install model dependencies in the exec env).
The only solution to this is to grant permissions to all users for the $HOME directory which is "/opt". That directory keeps pip cache, virtualenvs the the code.

We can't know which user will run this container but we definitely can't run the containers from root. Chainguard will never let us to use 1000 as a user - there is no way to create custom users, it only gives us nonroot user that we can use when running the container - that's requirement from STIG/FIPS compliance.

Also sorry, I didnt realize I commented on specifically julia.. Its an irrelevant env, so if any tests - definitely not the Julia one

Right, for that reason I updated all the Dockerfiles in this PR.

klichukb · 2025-05-14T10:36:51Z

public_dropin_environments/java_codegen/Dockerfile

-    find ${VIRTUAL_ENV} -type d -name '__pycache__' -exec rm -rf {} + && \
-    rm -rf /usr/bin/rm /usr/bin/find"
+# Copy preinstalled virtualenv
+COPY --from=build --chown=nonroot ${VIRTUAL_ENV} ${VIRTUAL_ENV}


this definitely needs testing with actual datarobot. we use 1000:1000 to run by default.

…l tests

peterzdeb · 2025-05-16T11:26:51Z

Drop-in environments are running with security context by LRS. Whatever we set in the Dockerfile can be overriden on runtime. Users who request that custom environments may wish to reinstall packages, including DRUM

Planning to close this PR as won't do.
cc @Mint-Martini

peterzdeb added 3 commits May 12, 2025 13:45

[RAPTOR-12499] Configuring nonroot user for Drop-In envs

66a5735

[RAPTOR-12499] Default USER nobody for dropin envs

124dd02

[RAPTOR-12499] Changelog update

0a7ccb9

engprod-2 bot changed the title ~~SemGrep detected root user in dronin environments~~ [RAPTOR-12499] SemGrep detected root user in dronin environments May 12, 2025

peterzdeb added 2 commits May 12, 2025 19:50

[RAPTOR-12499] Updating virtualenvs with nonroot permissions

1f31a64

[RAPTOR-12499] Updating virtualenvs with nonroot permissions

2f204fa

peterzdeb added the 00 - Ready for Review label May 13, 2025

devexp-slackbot bot added Needs Review: Core Modeling Needs Review: Custom Models Needs Review: GenAI Build (Buzok) Needs Review: Scoring Code Needs Review: Tracking-Agent labels May 13, 2025

peterzdeb commented May 13, 2025

View reviewed changes

svc-engprod-git1 requested a review from shopin32 May 13, 2025 15:03

devexp-slackbot bot removed the Needs Review: Scoring Code label May 13, 2025

shopin32 approved these changes May 13, 2025

View reviewed changes

tsdaemon approved these changes May 14, 2025

View reviewed changes

peterzdeb removed the Needs Review: GenAI Build (Buzok) label May 14, 2025

klichukb reviewed May 14, 2025

View reviewed changes

peterzdeb added 7 commits May 14, 2025 19:02

Merge branch 'master' into peterzdeb/RAPTOR-12499

3ce4e1f

[RAPTOR-12499] changelog rebase

c90d44d

[RAPTOR-12499] Allowing permissions for all users to HOME

0ce4c85

Merge branch 'master' into peterzdeb/RAPTOR-12499

98b854b

[RAPTOR-12499] Allowing permissions for all users to HOME

bd26dab

[RAPTOR-12499] Root required to change permissions

7228032

[RAPTOR-12499] Prepared unprotected stage in Dockerfile for functiona…

1c016e8

…l tests

[RAPTOR-12499] Prepared a separate Dockerfile for functional tests

0215004

peterzdeb removed Needs Review: Core Modeling Needs Review: Custom Models Needs Review: Tracking-Agent 00 - Ready for Review labels May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RAPTOR-12499] SemGrep detected `root` user in dronin environments #1423

[RAPTOR-12499] SemGrep detected `root` user in dronin environments #1423

peterzdeb commented May 12, 2025

Uh oh!

devexp-slackbot bot commented May 13, 2025

Uh oh!

peterzdeb May 13, 2025

Uh oh!

peterzdeb May 13, 2025

Uh oh!

peterzdeb May 13, 2025

Uh oh!

shopin32 left a comment

Uh oh!

tsdaemon left a comment

Uh oh!

klichukb May 14, 2025

Uh oh!

klichukb May 14, 2025

Uh oh!

peterzdeb May 14, 2025

Uh oh!

peterzdeb May 15, 2025

Uh oh!

klichukb May 15, 2025

Uh oh!

peterzdeb May 15, 2025

Uh oh!

klichukb May 14, 2025

Uh oh!

peterzdeb commented May 16, 2025

Uh oh!

Uh oh!

		COPY --from=build /usr/bin/rm /usr/bin/rm
		COPY --from=build /usr/bin/find /usr/bin/find

		python ensure_sh_shebang.py ${R_HOME}/bin && \
		mkdir -p /usr/share/doc/R/html && \

	/public_dropin_environments/python311_genai @datarobot/buzok @datarobot/codegen
	/public_dropin_environments/python311_genai_agents @datarobot/buzok @datarobot/codegen

[RAPTOR-12499] SemGrep detected root user in dronin environments #1423

Are you sure you want to change the base?

[RAPTOR-12499] SemGrep detected root user in dronin environments #1423

Conversation

peterzdeb commented May 12, 2025

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Summary

Rationale

Uh oh!

devexp-slackbot bot commented May 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shopin32 left a comment

Choose a reason for hiding this comment

Uh oh!

tsdaemon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peterzdeb commented May 16, 2025

Uh oh!

Uh oh!

[RAPTOR-12499] SemGrep detected `root` user in dronin environments #1423

[RAPTOR-12499] SemGrep detected `root` user in dronin environments #1423