allow --port=8000 to apply as override#33
Open
AlbertDeFusco wants to merge 2 commits intodatalayer:mainfrom
Open
allow --port=8000 to apply as override#33AlbertDeFusco wants to merge 2 commits intodatalayer:mainfrom
AlbertDeFusco wants to merge 2 commits intodatalayer:mainfrom
Conversation
Member
|
strange, relauched the test for python 3.11 on ubuntu and failing twice with the same error https://github.com/datalayer/mcp-compose/actions/runs/25073240867/job/73466337908?pr=33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out that when
--port=8000was explicitly provided on the CLI it would not override the mcp-compose.toml configuration but any other value would.This PR helps declare that when no
--portflag is passed the mcp-compose.toml is used otherwise set the port to 8000. But when --port is passed it has the highest priority.Here's an example of the case today with version 0.1.11
no port override
with port=8000 override
the mcp endpoint is still on 8888