-
Notifications
You must be signed in to change notification settings - Fork 21
Add custom UI for new in situ UV-Vis block #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 74.57% 74.58%
=======================================
Files 66 67 +1
Lines 4535 4536 +1
=======================================
+ Hits 3382 3383 +1
Misses 1153 1153
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
bes/uv-vis-reformat-for-plugin-dev
|
Run status |
|
Run duration | 07m 25s |
Commit |
|
Committer | Ben Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
0
|
|
0
|
|
0
|
|
384
|
View all changes introduced in this branch ↗︎ |
Tests for review
batchSampleFeature.cy.js • 1 failed test • End-to-end tests (electron)
Test | Artifacts | |
---|---|---|
Batch sample creation > uses the template id, name, date, copyFrom, and components |
Test Replay
Screenshots
|
editPage.cy.js • 1 failed test • End-to-end tests (electron)
Test | Artifacts | |
---|---|---|
Edit Page > Clicks the upload buttons and checks that the modals are shown |
Test Replay
Screenshots
|
Can we figure out what is failing here and merge it before datalab-org/datalab-app-plugin-insitu#45? |
It's trying to import UVVisInsituBlock from the plugin, I assume before the plugin exists in its version of datalab-app-insitu-plugin? When I am on my local version on branch bes/uv-vis-reformat-for-plugin-dev for datalab and bes/uv-vis-insitu-merge for datalab-app-insitu-plugin that test passes. I think we have to merge datalab-org/datalab-app-plugin-insitu#45 this one first |
Gotcha, will focus my reviewing there! |
…ur of scan time box for when it triggers a recalculation of the data
3fc7191
to
d232021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @be-smith!
I've just pushed a few of my own tweaks (creating a new FolderSelect
component which adds some basic styling to the folder names, and reorganising the input boxes to be a bit more responsive). Perhaps these could also be used for the in situ NMR block @BenjaminCharmes.
I think with one more round of feedback on the block code in the plugin (e.g., setting default values for granularity), this will be really nice, but lets not hold up this PR if the tests still pass.
Adds a custom component for the new in situ UV-vis block that closely mirrors the in situ NMR block.