Remove broken deployment.md link in INSTALL.md #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployment.md no longer exists, this removes the broken link in the first instance and changes the link to https://docs.datalab-org.io/en/stable/deployment/ in the second
yue-here
requested review from
jdbocarsly,
ml-evs and
BenjaminCharmes
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 71.73% 71.73%
=======================================
Files 66 66
Lines 4482 4482
=======================================
Hits 3215 3215
Misses 1267 1267 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
update-install-md
|
| Run status |
|
| Run duration | 08m 27s |
| Commit |
|
| Committer | Yue Wu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
A further reading of the docs shows that the authentication info is not in "deployment" but "configuration", link has been changed to reflect this.
ml-evs
reviewed
Jun 21, 2025
There was a problem hiding this comment.
This "internal" link actually works fine when rendered by the docs (https://docs.datalab-org.io/en/latest/INSTALL) -- I think I'm of the opinion that we should actually just move this file into the docs directly and link to it from the README, rather than maintaining it as a symlink. There's also lots of formatting that doesn't render properly on GitHub as its targeted at mkdocs, e.g., the tabbed uv vs venv instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployment.md no longer exists, this removes the broken link in the first instance and changes the link to https://docs.datalab-org.io/en/stable/deployment/ in the second