Skip to content

Update Bokeh to 3.4.3 #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update Bokeh to 3.4.3 #1240

wants to merge 5 commits into from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Jun 13, 2025

First attempt to update Bokeh to 3.x.x

Currently using 3.4.3, but could normally use an even newer version without problems (latest 3.7.3 (May 2025))

Need more discussion, I'll put it on ready to review if some people want to test locally.

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 48.33333% with 31 lines in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (05f7618) to head (f0b6fed).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/bokeh_plots.py 57.50% 17 Missing ⚠️
pydatalab/src/pydatalab/apps/echem/blocks.py 0.00% 2 Missing ⚠️
pydatalab/src/pydatalab/apps/eis/__init__.py 0.00% 2 Missing ⚠️
pydatalab/src/pydatalab/apps/ftir/__init__.py 0.00% 2 Missing ⚠️
pydatalab/src/pydatalab/apps/raman/blocks.py 0.00% 2 Missing ⚠️
pydatalab/src/pydatalab/apps/uvvis/__init__.py 0.00% 2 Missing ⚠️
pydatalab/src/pydatalab/apps/xrd/blocks.py 33.33% 2 Missing ⚠️
pydatalab/src/pydatalab/blocks/common.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   71.73%   71.53%   -0.20%     
==========================================
  Files          66       66              
  Lines        4482     4515      +33     
==========================================
+ Hits         3215     3230      +15     
- Misses       1267     1285      +18     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/apps/nmr/blocks.py 78.57% <100.00%> (+0.15%) ⬆️
pydatalab/src/pydatalab/apps/tga/blocks.py 73.58% <100.00%> (+0.50%) ⬆️
pydatalab/src/pydatalab/apps/echem/blocks.py 27.18% <0.00%> (-0.27%) ⬇️
pydatalab/src/pydatalab/apps/eis/__init__.py 47.36% <0.00%> (-1.29%) ⬇️
pydatalab/src/pydatalab/apps/ftir/__init__.py 67.34% <0.00%> (-1.41%) ⬇️
pydatalab/src/pydatalab/apps/raman/blocks.py 80.00% <0.00%> (-0.63%) ⬇️
pydatalab/src/pydatalab/apps/uvvis/__init__.py 54.16% <0.00%> (-0.77%) ⬇️
pydatalab/src/pydatalab/apps/xrd/blocks.py 62.23% <33.33%> (-0.44%) ⬇️
pydatalab/src/pydatalab/blocks/common.py 58.88% <0.00%> (-0.67%) ⬇️
pydatalab/src/pydatalab/bokeh_plots.py 79.21% <57.50%> (-2.61%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Jun 13, 2025

datalab    Run #3476

Run Properties:  status check failed Failed #3476  •  git commit a74b3b0a4f ℹ️: Merge f0b6fedb80152e711d54f64b88436011b53bf8b6 into 66be21f5343304ebf7a9c1486583...
Project datalab
Branch Review bc/update-bokeh
Run status status check failed Failed #3476
Run duration 05m 52s
Commit git commit a74b3b0a4f ℹ️: Merge f0b6fedb80152e711d54f64b88436011b53bf8b6 into 66be21f5343304ebf7a9c1486583...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 144
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/editPage.cy.js • 2 failed tests • End-to-end tests (firefox)

View Output

Test Artifacts
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Screenshots
Edit Page > Uploads an Raman data file, makes a Raman block and checks that the plot is shown Screenshots
Failed  cypress/e2e/editPage.cy.js • 2 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Test Replay Screenshots
Edit Page > Uploads an Raman data file, makes a Raman block and checks that the plot is shown Test Replay Screenshots
Failed  cypress/e2e/editPage.cy.js • 2 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Test Replay Screenshots
Edit Page > Uploads an Raman data file, makes a Raman block and checks that the plot is shown Test Replay Screenshots

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review June 17, 2025 11:02
@ml-evs ml-evs added the on-hold label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants