Skip to content

[WIP] Add yields section to synthesis tables and models #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 13, 2025

Initial work on adding products/yields to synthesis information. Probably blocked by #1101 at the moment.

Addresses #1089

This PR adds a synthesis_products field that is by default added with a self-loop to the current sample.

Things to consider:

  • Should we ban self-loops elsewhere in this description?
  • Should the model be extended to specify both yield % and amount + unit, or should yield always be computed dynamically? (or equivalently, should yield % be an allowed value for amount + unit itself if computed externally)

@ml-evs ml-evs added this to the v0.6.x milestone Apr 13, 2025
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.33%. Comparing base (c80ea21) to head (98897f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
+ Coverage   70.28%   70.33%   +0.05%     
==========================================
  Files          63       63              
  Lines        4133     4140       +7     
==========================================
+ Hits         2905     2912       +7     
  Misses       1228     1228              
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/models/samples.py 97.29% <100.00%> (+0.63%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/items.py 83.38% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 13, 2025

datalab    Run #3527

Run Properties:  status check failed Failed #3527  •  git commit b37394b2b4 ℹ️: Merge 7bbfed05069239fa57742197a533084a6cc70f0c into c51623496dfb3e4766384289dfc2...
Project datalab
Branch Review ml-evs/yields
Run status status check failed Failed #3527
Run duration 08m 21s
Commit git commit b37394b2b4 ℹ️: Merge 7bbfed05069239fa57742197a533084a6cc70f0c into c51623496dfb3e4766384289dfc2...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 33
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 117
View all changes introduced in this branch ↗︎

Tests for review

Failed  batchSampleFeature.cy.js • 5 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Failed  editPage.cy.js • 3 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots
Failed  sampleTablePage.cy.js • 3 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Advanced sample creation features > modifies some data in the second sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Test Replay Screenshots
Failed  batchSampleFeature.cy.js • 5 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Failed  editPage.cy.js • 3 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots

The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.

@ml-evs ml-evs modified the milestones: v0.7.x, v0.6.x May 20, 2025
@ml-evs ml-evs added the on-hold label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant