Add centralized request error handling to base client class #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual error handling in all HTTP request methods with calls to centralized _get(), _post(), and _put() methods from the base class. Changes: - Remove repetitive status code and JSON status checks - Use _get() for GET requests: get_info, get_block_info, get_items, search_items, get_item, get_collection - Use _post() for POST requests: create_item, update_item, get_block, upload_file, create_data_block, _update_data_block - Use _put() for PUT requests: create_collection - Maintain existing custom error handling for authenticate() method - Significantly reduce code duplication and improve maintainability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ml-evs
force-pushed
the
ml-evs/show-errors
branch
from
977fc4b to
61095be
Compare
- 401/403: Authentication guidance with API key setup instructions - 404: Helpful message about checking URL/endpoint correctness - 429: Rate limiting guidance - 500: Server bug reporting with server version info - 502: Gateway connectivity issues - 503: Service unavailable with deployment issue reporting - 504: Gateway timeout guidance - Show response content for JSON parsing errors on successful responses 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ml-evs
force-pushed
the
ml-evs/show-errors
branch
from
61095be to
ece3090
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 37.01% 42.97% +5.95%
==========================================
Files 5 5
Lines 489 491 +2
==========================================
+ Hits 181 211 +30
+ Misses 308 280 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR centralises request handling into the base class, to allow for much cleaner error reporting. It also refactors tests to use respx_mock as a fixture, and adds several new tests for awkward cases.
Closes #69