-
Notifications
You must be signed in to change notification settings - Fork 115
Update how git scripts find remotes #5953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @juliawu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness and flexibility of two key shell scripts, Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the logic for finding git remotes in two scripts, making them more robust by handling cases where multiple remotes might match the search criteria. The changes are logical and well-commented. I've provided a few suggestions to further improve the consistency and simplify the command pipelines.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| # Usage: ./scripts/update_git_submodules.sh from root directory | ||
|
|
||
| git submodule foreach git pull origin master | ||
| # Detect the name of your forked repo (i.e. not the main repo 'datacommonsorg') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want this to run on the main datacommonsorg repo? For me, origin points to [email protected]:datacommonsorg/website.git and the script appears to be running properly
Tweaks the logic in our convenience scripts to find the names of git remotes more intelligently. More specifically:
update_prod_tag.sh
It's possible that there are multiple remotes that match
datacommonsorg. For example, if folks follow the instructions in the README when setting up their forks to adddcas a remote manually, they will have both remotesdcandupstreamfor the datacommonsorg/website repo.This PR adds
head -n 1to the script so that only one is selected. Otherwise, the script fails when trying to accessdc upstream, which doesn't exist.update_git_submodules.sh
Similarly, this script previously assumed the caller's remote fork was named
origin. The name of the remote fork is now dynamically fetched by the script.