Skip to content

Disable V3 mirroring on prod#1795

Closed
n-h-diaz wants to merge 3 commits intodatacommonsorg:masterfrom
n-h-diaz:disable
Closed

Disable V3 mirroring on prod#1795
n-h-diaz wants to merge 3 commits intodatacommonsorg:masterfrom
n-h-diaz:disable

Conversation

@n-h-diaz
Copy link
Contributor

@n-h-diaz n-h-diaz commented Mar 3, 2026

Set V3MirrorFraction to the default value (

V3MirrorFraction: 0.0,
) for prod mixer/website

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to completely disable V3 mirroring in the production environment. By setting the V3MirrorFraction to zero, all traffic mirroring to the V3 system is halted, ensuring that production resources are not consumed by this process. This change impacts both the core mixer service and the public-facing website.

Highlights

  • V3 Mirroring Disabled: The V3MirrorFraction feature flag has been set to 0 in the production configuration for both the mixer and the website, effectively disabling V3 mirroring.
Changelog
  • deploy/featureflags/prod.yaml
    • Changed V3MirrorFraction from 0.6 to 0.
  • deploy/featureflags/prod_website.yaml
    • Changed V3MirrorFraction from 0.6 to 0.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly disables V3 mirroring in production by setting V3MirrorFraction to 0. My feedback suggests an improvement for consistency: since 0 is the default value for this flag, the explicit setting can be removed from the configuration files. This aligns with the apparent convention in your project of only specifying non-default flag values, which makes the configuration files cleaner. The comments are retained as they do not contradict any provided rules.

@n-h-diaz n-h-diaz marked this pull request as ready for review March 3, 2026 23:29
@n-h-diaz n-h-diaz requested a review from dhotchkiss March 3, 2026 23:29
@n-h-diaz
Copy link
Contributor Author

n-h-diaz commented Mar 4, 2026

Closing since we did a cherry pick release instead

@n-h-diaz n-h-diaz closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant