Disable V3 mirroring on prod#1795
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to completely disable V3 mirroring in the production environment. By setting the V3MirrorFraction to zero, all traffic mirroring to the V3 system is halted, ensuring that production resources are not consumed by this process. This change impacts both the core mixer service and the public-facing website. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request correctly disables V3 mirroring in production by setting V3MirrorFraction to 0. My feedback suggests an improvement for consistency: since 0 is the default value for this flag, the explicit setting can be removed from the configuration files. This aligns with the apparent convention in your project of only specifying non-default flag values, which makes the configuration files cleaner. The comments are retained as they do not contradict any provided rules.
|
Closing since we did a cherry pick release instead |
Set V3MirrorFraction to the default value (
mixer/internal/featureflags/featureflags.go
Line 49 in 318b9b3