Skip to content

[Migration] delete search endpoint from code#1792

Merged
yiyche merged 4 commits intodatacommonsorg:masterfrom
yiyche:search_dc_deletion
Mar 4, 2026
Merged

[Migration] delete search endpoint from code#1792
yiyche merged 4 commits intodatacommonsorg:masterfrom
yiyche:search_dc_deletion

Conversation

@yiyche
Copy link
Member

@yiyche yiyche commented Mar 3, 2026

All apigee traffic to search endpoint has been blocked and website /search_dc now redirects to /search.

@yiyche yiyche requested a review from n-h-diaz March 3, 2026 02:40
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on removing the deprecated Search endpoint from the Mixer service. This action is a direct response to the blocking of all Apigee traffic to this endpoint and the redirection of the /search_dc website to /search, rendering the old endpoint obsolete. The changes streamline the codebase by eliminating unused RPC definitions, client/server implementations, and the dedicated search logic file, contributing to a cleaner and more maintainable system.

Highlights

  • Deprecated Search Endpoint Removal: The Search RPC endpoint and its associated code have been entirely removed from the Mixer service.
  • Codebase Cleanup: This change cleans up the codebase by eliminating unused gRPC definitions, client/server implementations, and the underlying search logic file.
Changelog
  • internal/proto/service/mixer_grpc.pb.go
    • Removed the Mixer_Search_FullMethodName constant.
    • Removed the Search method from the MixerClient interface.
    • Removed the Search method from the MixerServer interface.
    • Removed the Search method implementation from mixerClient.
    • Removed the Search method implementation from UnimplementedMixerServer.
    • Removed the _Mixer_Search_Handler function.
    • Removed the Search entry from Mixer_ServiceDesc.
  • internal/server/handler.go
    • Removed the import for the internal/server/search package.
    • Removed the Search method implementation from the Server struct.
  • internal/server/search/search.go
    • The entire file containing the Search logic was removed.
  • proto/service/mixer.proto
    • Removed the Search RPC definition, including its deprecated option and google.api.http annotation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated /search endpoint. The changes are straightforward, involving the deletion of the RPC definition in mixer.proto, its implementation in handler.go and search.go, and the corresponding generated code. The removal appears complete within the scope of the modified files.

Copy link
Contributor

@n-h-diaz n-h-diaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yiyche yiyche added this pull request to the merge queue Mar 4, 2026
Merged via the queue into datacommonsorg:master with commit 094c887 Mar 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants