[DCP Docker Push] Simplify cloudbuild#14
[DCP Docker Push] Simplify cloudbuild#14gmechali wants to merge 2 commits intodatacommonsorg:mainfrom
Conversation
Summary of ChangesHello @gmechali, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to simplify the Cloud Build configuration for the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the cloudbuild.yaml by removing explicit docker push steps and relying on the images directive, which is a good improvement. I've added one comment regarding a missing newline at the end of the file, which is a common convention for text files.
build/cloudbuild.yaml
Outdated
| images: | ||
| - 'gcr.io/datcom-ci/datacommons-platform:latest' | ||
| - 'gcr.io/datcom-ci/datacommons-platform:$COMMIT_SHA' | ||
| - 'gcr.io/datcom-ci/datacommons-platform:$COMMIT_SHA' No newline at end of file |
We do not need the explicit docker push command.
Small simplification.
The plan is to use this cloudbuild.yaml on 2 triggers:
Also migrates to using the new format for the artifact registry repo path. Verified by running local, see images generated in https://pantheon.corp.google.com/artifacts/docker/datcom-ci/us/gcr.io/datacommons-platform?e=13803378&inv=1&invt=Ab3CEA&mods=-monitoring_api_staging&project=datcom-ci