Skip to content

[DCP Docker Push] Simplify cloudbuild#14

Open
gmechali wants to merge 2 commits intodatacommonsorg:mainfrom
gmechali:build
Open

[DCP Docker Push] Simplify cloudbuild#14
gmechali wants to merge 2 commits intodatacommonsorg:mainfrom
gmechali:build

Conversation

@gmechali
Copy link

@gmechali gmechali commented Feb 24, 2026

We do not need the explicit docker push command.
Small simplification.

The plan is to use this cloudbuild.yaml on 2 triggers:

  • There is a pubsub that gets periodically triggered to update all our images
  • On each PR merge in the datacommonsorg/datacommons repo.

Also migrates to using the new format for the artifact registry repo path. Verified by running local, see images generated in https://pantheon.corp.google.com/artifacts/docker/datcom-ci/us/gcr.io/datacommons-platform?e=13803378&inv=1&invt=Ab3CEA&mods=-monitoring_api_staging&project=datcom-ci

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gmechali, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to simplify the Cloud Build configuration for the datacommons-platform Docker image. By removing explicit docker push commands, the build process becomes more concise and relies on Cloud Build's native image handling capabilities, facilitating automated image updates for various triggers.

Highlights

  • Cloud Build Simplification: The cloudbuild.yaml configuration has been streamlined by removing redundant explicit docker push commands. Cloud Build's images field now handles the pushing of the built Docker images automatically.
Changelog
  • build/cloudbuild.yaml
    • Removed two docker steps that explicitly pushed the latest and $COMMIT_SHA tagged images.
    • Reformatted the args list for the docker build step to be more readable, splitting arguments onto separate lines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the cloudbuild.yaml by removing explicit docker push steps and relying on the images directive, which is a good improvement. I've added one comment regarding a missing newline at the end of the file, which is a common convention for text files.

images:
- 'gcr.io/datcom-ci/datacommons-platform:latest'
- 'gcr.io/datcom-ci/datacommons-platform:$COMMIT_SHA'
- 'gcr.io/datcom-ci/datacommons-platform:$COMMIT_SHA' No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a good practice for text files to end with a newline character. This ensures compatibility with various command-line tools and prevents potential issues with file processing.

  - 'gcr.io/datcom-ci/datacommons-platform:$COMMIT_SHA'

@gmechali gmechali requested a review from dwnoble February 24, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant