Import : College_Admissions_IPEDS_National : auto refresh config#1819
Import : College_Admissions_IPEDS_National : auto refresh config#1819vishalworkdatacommon wants to merge 4 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello @vishalworkdatacommon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new, fully automated data import for national college admissions and enrollment figures from the IPEDS database. The changes introduce a robust pipeline capable of downloading raw data, processing it through a statistical variable processor, and generating ready-to-ingest artifacts. This ensures up-to-date and consistent data availability for a wide range of academic years. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new automated import for College Admissions data from IPEDS. The changes are well-structured, including documentation, configuration files, processing scripts, and test data.
My review focuses on improving maintainability and consistency. I've identified several areas with code/config duplication in manifest.json and the pv_map files, which could be consolidated. There are also some inconsistencies between the manual run.sh script and the automated configuration in manifest.json that should be addressed. Finally, I've pointed out a few typos in the README.md file.
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2014.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2014.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2014", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2015.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2015.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2015", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2016.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2016.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2016", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2017.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2017.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2017", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2018.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2018.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2018", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2019.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2019.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2019", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2020.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2020.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2020", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2021.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2021.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2021", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2022.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2022.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2022", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2023.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2023.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2023" |
There was a problem hiding this comment.
The scripts array contains many repetitive calls to stat_var_processor.py. This violates the DRY (Don't Repeat Yourself) principle and makes the manifest harder to maintain when adding new years. Consider creating a Python script that loops through the years (similar to run.sh) and calling that single script from here. This would simplify the manifest significantly.
...var_imports/ipeds/college_admission_national/pv_map/college_admissions_ipeds_pv_map_2014.csv
Show resolved
Hide resolved
...var_imports/ipeds/college_admission_national/pv_map/college_admissions_ipeds_pv_map_2014.csv
Show resolved
Hide resolved
| "provenance_description": "Data on student applications, admissions, and enrollment for postsecondary institutions across the United States.", | ||
| "scripts": [ | ||
| "download_script.py", | ||
| "../../tools/statvar_importer/stat_var_processor.py --existing_statvar_mcf=admissions_stat_vars_common.mcf --input_data=input_files/college_admissions_2014.csv --pv_map=pv_map/college_admissions_ipeds_pv_map_2014.csv --config_file=college_admissions_ipeds_metadata.csv --output_path=output_files/admissions_output_2014", |
There was a problem hiding this comment.
admissions_stat_vars_common.mcf file is missing
There was a problem hiding this comment.
addressed.
3 participants
No description provided.