Open
Conversation
* Explicit support and testing against Python 3.13 and 3.14 ([#228](#228)). The project's configuration and workflows have been updated to improve testing, dependency management, and support for the latest Python versions. Notably, the acceptance workflow now runs integration tests for draft pull requests, and the Hatch version has been upgraded to 1.16.5. The GitHub Actions workflow has been updated to use the latest versions of actions, including `actions/checkout@v6` and `actions/setup-python@v6`, and the Python version has been upgraded to 3.14. Environment variables `HATCH_VERBOSE` and `HATCH_VERSION` have been added, with `HATCH_VERBOSE` set to 2 and `HATCH_VERSION` set to 1.16.5. Additionally, the project's tooling has been refreshed, including upgrades to mypy, pylint, and pytest, and the configuration for running tests has been updated to include integration tests and matrix testing across multiple Python versions. Various code updates have also been made, including changes to type hints, the removal of unnecessary type parameters, and the addition of a `_not_none` function to handle potential `None` values. These changes aim to enhance the project's testing and setup process, ensure better support for the latest Python versions and tools, and improve code readability and maintainability. * Fixed issue 216 - name is required in serving config ([#224](#224)). The library has been updated to improve consistency and compatibility with the API behavior. The `_make_workspace_client` function now expects the `scopes` parameter to be a string, specifically "all-apis", to match the `ClientCredentials` signature. Additionally, the `EndpointCoreConfigInput` requires a `name` parameter, and the `served_entities` parameter is used instead of the deprecated `served_models`. The `create` function has been updated to use these new inputs and outputs, creating an endpoint with the required `name` and updated `served_entities` configuration, and returning a `ServingEndpointDetailed` object with a `pending_config` that includes both `served_models` and `served_entities` for compatibility. Furthermore, several test functions have been modified to access the `entity_name` and `entity_version` attributes of the `served_entities` list, ensuring the tests remain valid and verify the correct behavior of the `make_serving_endpoint` function with the new configuration. * [make_job] Allow passing serverless environments ([#227](#227)). The `make_job` function has been enhanced to provide users with more control over the execution environment of their tasks when using serverless compute. A new `environments` keyword argument has been introduced, allowing users to optionally pass a list of serverless environments, which is required for running Spark Python tasks and can override the notebook environment for Databricks Notebook tasks. This argument can be used in conjunction with other existing keyword arguments to create a job with a specific set of tasks and environments. The update enables users to specify serverless environments for their jobs, providing more flexibility and control over their compute resources, and includes backward compatibility with existing functionality, as demonstrated by updated test cases that verify the correct handling of the `environments` argument.
pritishpai
approved these changes
Mar 23, 2026
|
✅ 40/40 passed, 6 skipped, 14m59s total Running from acceptance #241 |
asnare
reviewed
Mar 24, 2026
Contributor
asnare
left a comment
There was a problem hiding this comment.
Sigh, the tests are all failing due to the SDK issue I mentioned in standup: Config from the SDK now makes a network call to enrich itself based on workspace metadata. For unit tests this fails because the host doesn't exist, and the initialiser goes into a fruitless retry-loop until the test timeout is hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/checkout@v6andactions/setup-python@v6, and the Python version has been upgraded to 3.14. Environment variablesHATCH_VERBOSEandHATCH_VERSIONhave been added, withHATCH_VERBOSEset to 2 andHATCH_VERSIONset to 1.16.5. Additionally, the project's tooling has been refreshed, including upgrades to mypy, pylint, and pytest, and the configuration for running tests has been updated to include integration tests and matrix testing across multiple Python versions. Various code updates have also been made, including changes to type hints, the removal of unnecessary type parameters, and the addition of a_not_nonefunction to handle potentialNonevalues. These changes aim to enhance the project's testing and setup process, ensure better support for the latest Python versions and tools, and improve code readability and maintainability._make_workspace_clientfunction now expects thescopesparameter to be a string, specifically "all-apis", to match theClientCredentialssignature. Additionally, theEndpointCoreConfigInputrequires anameparameter, and theserved_entitiesparameter is used instead of the deprecatedserved_models. Thecreatefunction has been updated to use these new inputs and outputs, creating an endpoint with the requirednameand updatedserved_entitiesconfiguration, and returning aServingEndpointDetailedobject with apending_configthat includes bothserved_modelsandserved_entitiesfor compatibility. Furthermore, several test functions have been modified to access theentity_nameandentity_versionattributes of theserved_entitieslist, ensuring the tests remain valid and verify the correct behavior of themake_serving_endpointfunction with the new configuration.make_jobfunction has been enhanced to provide users with more control over the execution environment of their tasks when using serverless compute. A newenvironmentskeyword argument has been introduced, allowing users to optionally pass a list of serverless environments, which is required for running Spark Python tasks and can override the notebook environment for Databricks Notebook tasks. This argument can be used in conjunction with other existing keyword arguments to create a job with a specific set of tasks and environments. The update enables users to specify serverless environments for their jobs, providing more flexibility and control over their compute resources, and includes backward compatibility with existing functionality, as demonstrated by updated test cases that verify the correct handling of theenvironmentsargument.