Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
===========================================
- Coverage 65.23% 13.47% -51.77%
===========================================
Files 100 105 +5
Lines 8504 8673 +169
Branches 875 875
===========================================
- Hits 5548 1169 -4379
- Misses 2769 7445 +4676
+ Partials 187 59 -128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ 129/130 passed, 8 flaky, 1 failed, 5 skipped, 30m28s total ❌ test_recon_databricks_job_succeeds: TimeoutError: timed out after 0:20:00: (20m47.393s)Flaky tests:
Running from acceptance #3666 |
| from databricks.labs.lakebridge.connections.database_manager import DatabaseManager | ||
|
|
||
|
|
||
| def get_sqlserver_reader( |
Collaborator
There was a problem hiding this comment.
Database manager should already have the MSSQLConnector we should be using that.
| steps: | ||
| - name: activity_extract | ||
| type: python | ||
| extract_source: src/databricks/labs/lakebridge/resources/assessments/mssql/activity_extract.py |
Collaborator
There was a problem hiding this comment.
Can't we just run sql queries directly? do we need python wrapper for SQL Server profilers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This PR adds a new profiler for
mssql.Relevant implementation details
This profiler closely follows the implementation of the Azure Synapse profiler. However, this implementation provides a
last_execution_timeparam for allmssqlserver queries, allowing for a future scheduler component to hook in an repeat queries.Caveats/things to watch out for when reviewing:
This profiler will not support on-prem
mssqlservers.Linked issues
N/A
Functionality
databricks labs lakebridge ...Tests