Skip to content

Issue 243 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ravi-databricks wants to merge 5 commits into
base: feature/v0.0.11
Choose a base branch
from
Open

Issue 243 #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07f7608
Update dataflow_pipeline.py to use quarantine_table instead of quaran…
junhonglau Nov 19, 2025
898b85b
Merge pull request #1 from junhonglau/issues#243
junhonglau Nov 19, 2025
73bee9e
Update dataflow_pipeline.py
junhonglau Nov 21, 2025
3488d45
Merge pull request #245 from junhonglau/main
ravi-databricks Feb 11, 2026
c935ef0
added unit tests for q table pr
ravi-databricks Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/dataflow_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def write_layer_with_dqe(self):
dlt_table_with_expectation = dlt.expect_all(expect_all_dict)(
dlt.table(
self.write_to_delta,
name=f"{target_table_name}",
name=f"{target_table}",
table_properties=self.dataflowSpec.tableProperties,
partition_cols=DataflowSpecUtils.get_partition_cols(self.dataflowSpec.partitionColumns),
cluster_by=DataflowSpecUtils.get_partition_cols(self.dataflowSpec.clusterBy),
Expand All @@ -503,7 +503,7 @@ def write_layer_with_dqe(self):
dlt_table_with_expectation = dlt.expect_all_or_fail(expect_all_or_fail_dict)(
dlt.table(
self.write_to_delta,
name=f"{target_table_name}",
name=f"{target_table}",
table_properties=self.dataflowSpec.tableProperties,
partition_cols=DataflowSpecUtils.get_partition_cols(self.dataflowSpec.partitionColumns),
cluster_by=DataflowSpecUtils.get_partition_cols(self.dataflowSpec.clusterBy),
Expand All @@ -520,7 +520,7 @@ def write_layer_with_dqe(self):
dlt_table_with_expectation = dlt.expect_all_or_drop(expect_all_or_drop_dict)(
dlt.table(
self.write_to_delta,
name=f"{target_table_name}",
name=f"{target_table}",
table_properties=self.dataflowSpec.tableProperties,
partition_cols=DataflowSpecUtils.get_partition_cols(self.dataflowSpec.partitionColumns),
cluster_by=DataflowSpecUtils.get_partition_cols(self.dataflowSpec.clusterBy),
Expand Down Expand Up @@ -588,7 +588,7 @@ def write_layer_with_dqe(self):
dlt.expect_all_or_drop(expect_or_quarantine_dict)(
dlt.table(
self.write_to_delta,
name=f"{quarantine_table_name}",
name=f"{quarantine_table}",
table_properties=self.dataflowSpec.quarantineTableProperties,
partition_cols=q_partition_cols,
cluster_by=q_cluster_by,
Expand Down
6 changes: 3 additions & 3 deletions tests/test_dataflow_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ def test_dlt_write_silver(self, mock_dlt):
target_path_uc, target_table_uc, target_table_name_uc = pipeline_uc._get_target_table_info()
expected_comment_uc = pipeline_uc._get_table_comment(target_table_uc, is_bronze=False)
self.assertEqual(args[0], pipeline_uc.write_to_delta)
self.assertEqual(kwargs["name"], target_table_name_uc)
self.assertEqual(kwargs["name"], target_table_uc)
self.assertIsNone(target_path_uc)
self.assertIsNone(kwargs["path"])
self.assertEqual(kwargs["comment"], expected_comment_uc)
Expand All @@ -684,7 +684,7 @@ def test_dlt_write_silver(self, mock_dlt):
mock_dlt_table.assert_called_once()
args, kwargs = mock_dlt_table.call_args
self.assertEqual(args[0], pipeline_no_uc.write_to_delta)
self.assertEqual(kwargs["name"], target_table_name_no_uc)
self.assertEqual(kwargs["name"], target_table_no_uc)
self.assertEqual(kwargs["path"], target_path_no_uc)
self.assertEqual(kwargs["comment"], expected_comment_no_uc)

Expand Down Expand Up @@ -814,7 +814,7 @@ def test_dataflowpipeline_bronze_dqe(self, mock_dlt):
_, kwargs = mock_dlt_table.call_args_list[0]
target_path_actual, target_table, target_table_name = pipeline._get_target_table_info()
expected_comment = pipeline._get_table_comment(target_table, is_bronze=True)
self.assertEqual(kwargs["name"], target_table_name)
self.assertEqual(kwargs["name"], target_table)
expected_table_properties = (
dict(bronze_dataflow_spec.tableProperties)
if bronze_dataflow_spec.tableProperties
Expand Down