Speed up Claude and Codex launches - #407
Open
rohita5l wants to merge 1 commit into
Open
Conversation
rohita5l
force-pushed
the
codex-settings-first-launch-clean
branch
from
August 28, 2026 02:20
c1b0fd2 to
b34d1d5
Compare
rohita5l
force-pushed
the
codex-settings-first-launch-clean
branch
from
August 28, 2026 02:30
b34d1d5 to
00892fa
Compare
lilly-luo
reviewed
Aug 28, 2026
Comment on lines
+587
to
+588
| else: | ||
| state[WEB_SEARCH_MCP_STATE_KEY] = web_search_entry |
Collaborator
There was a problem hiding this comment.
this is redundant right? if the mcp is current, you dont need to reset it
lilly-luo
reviewed
Aug 28, 2026
| else: | ||
| state[WEB_SEARCH_MCP_STATE_KEY] = web_search_entry | ||
| else: | ||
| state.pop(WEB_SEARCH_MCP_STATE_KEY, None) |
Collaborator
There was a problem hiding this comment.
nit for easier reading
if web_search_model:
web_search_entry = _web_search_mcp_entry(
state["workspace"], web_search_model, state.get("profile")
)
if not _web_search_mcp_is_current(state, web_search_entry):
# _register_web_search_mcp runs multiple `claude mcp` sub processes and can take 0.8s
_registration_success = _register_web_search_mcp(state["workspace"], web_search_model, state.get("profile")):
if _registration_success:
state[WEB_SEARCH_MCP_STATE_KEY] = web_search_entry
else:
state.pop(WEB_SEARCH_MCP_STATE_KEY, None)
lilly-luo
reviewed
Aug 28, 2026
| return False | ||
| if refresh or model or explicit_provider is not None: | ||
| return False | ||
| if enable_smart_routing_flag or skip_preflight: |
Collaborator
There was a problem hiding this comment.
? if we're only using the fast path when smart routing is disabled, this means smart routing is going to miss out on the speed up? isn't the goal to make smart routing the default on isaac so it means it would be slow?
lilly-luo
reviewed
Aug 28, 2026
| bool, | ||
| typer.Option( | ||
| "--refresh", | ||
| help="Refresh Databricks auth, gateway, models, managed config, and Codex configuration " |
Collaborator
There was a problem hiding this comment.
nit put this help into a const and either drop or parameterize Codex / Claude btw the both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--refreshto explicitly refresh Databricks auth, gateway, models, managed config, and agent configurationucode configure; agent launch commands never install themTesting