fix non-atomic replica number read populating hashring #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchen-db
force-pushed
the
yuchen-db/p-fix-replica-non-atomic
branch
from
5a1476c to
099b76b
Compare
jnyi
approved these changes
Oct 22, 2025
jnyi
left a comment
jnyi
left a comment
There was a problem hiding this comment.
lgtm, thanks for the fix, seems like it is because getStsDesiredReplicas would return inconsistent results
jnyi
reviewed
Oct 22, 2025
| var endpoints []receive.Endpoint | ||
|
|
||
| for _, sts := range stsList { | ||
| desiredReplicas, err := c.getStsDesiredReplicas(ctx, sts) |
There was a problem hiding this comment.
inconsistent to get desired replicas in hashring controller, maybe we should fix in our internal version too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this causes some ingestion dips when scaling up