[Internal] Unified Provider support for UC resources #5149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricks into go-sdk-unified-1
…ricks into go-sdk-unified-1
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
changed the title
tanmay-db
changed the title
tanmay-db
changed the title
mgyucht
reviewed
Oct 24, 2025
catalog/resource_catalog.go
Outdated
| d.SetId(ci.Name) | ||
|
|
||
| // Bind the current workspace if the catalog is isolated, otherwise the read will fail | ||
| return bindings.AddCurrentWorkspaceBindings(ctx, d, w, ci.Name, bindings.BindingsSecurableTypeCatalog) |
Contributor
There was a problem hiding this comment.
This probably needs to be moved up to the top of Update(), otherwise the WorkspaceClient used when changing provider_config.workspace_id may not have access to the isolated catalog (unless that workspace also happens to have a workspace binding separately).
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
reviewed
Dec 8, 2025
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
In general should be ok, but we may need to discuss how to handle bindings
| updateCatalogRequest.Name = d.Id() | ||
|
|
||
| // Bind the current workspace if the catalog is isolated, otherwise the read will fail | ||
| err = bindings.AddCurrentWorkspaceBindings(ctx, d, w, updateCatalogRequest.Name, bindings.BindingsSecurableTypeCatalog) |
Contributor
There was a problem hiding this comment.
Hmmm, typically the binding is done on creation. Should we add a check if the isolation mode is changing?
| // Bind the current workspace if the catalog is isolated, otherwise the read will fail | ||
| err = bindings.AddCurrentWorkspaceBindings(ctx, d, w, updateCatalogRequest.Name, bindings.BindingsSecurableTypeCatalog) | ||
| if err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
We also need to handle error like this: https://github.com/databricks/terraform-provider-databricks/pull/5149/files#diff-2dee1865e5fcab955309d55246c5d88e1692d4ea8008c9d5c133505fa6877130R187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Unified Provider Support for the following resources:
Note: UC Resources will not have
NamespaceCustomizeDiffwhich doesd.ForceNewTests
Added in main branch
NO_CHANGELOG=true