Added functionality for export of failure logs#591
Conversation
|
Let's elaborate on testing details, maybe include a redacted log JSON ? |
|
From your JSON, can we skip null fields while building the telemetry request? |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
samikshya-db
left a comment
There was a problem hiding this comment.
LGTM. thanks for getting this through 🎉
What type of PR is this?
Description
Added error logging to the init function of Error class
Added export_failure_log to TelemetryClient
How is this tested?
Unit tests
E2E Tests
Manually
Queried from a non-existent table
Request Body Summary:
uploadTime: 1749620674701
items: 0 items
protoLogs: 2 logs
N/A
The coverage of
telemetry_client.pybytest_telemetry.py's unit tests are as below.telemetry_client.pyRelated Tickets & Documents
PECOBLR-524