Skip to content

Hide token from console during configuration. #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Hide token from console during configuration. #123

wants to merge 6 commits into from

Conversation

andrewmchen
Copy link
Contributor

We should hide the token from the console during configuration for security purposes.

smurching
smurching approved these changes Jun 8, 2018
View reviewed changes
Copy link
Contributor

@smurching smurching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarondav aarondav added the LGTM label Aug 7, 2018
@areese areese mentioned this pull request Jul 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@smurching smurching smurching approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewmchen @smurching @aarondav