Skip to content

Fix: Vulnerability for guava #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Krish-cloudsufi
Copy link
Contributor

Issue:
Resolved a high-severity information disclosure vulnerability (CVE-2023-2976) related to insecure temporary file handling in the FileBackedOutputStream class of the Guava library (com.google.guava:guava). This vulnerability affects versions 1.0 through 31.1 on Unix-based systems and Android Ice Cream Sandwich. In vulnerable versions, temporary files were created in the system's default temporary directory (/tmp), allowing local users or applications with access to the directory to potentially read or tamper with those files.

Root Cause:
Guava used Java's default temporary directory for storing files without proper isolation, which could expose sensitive data in shared environments.

Fix:
Removed the explicit dependency on Guava from the Salesforce plugin

pom.xml Outdated
Comment on lines 757 to 764
<dependencies>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>31.0.1-jre</version>
<scope>compile</scope>
</dependency>
</dependencies>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we skip this as it is not showing up in the list of guava CVE's
/opt/connectors/lib/salesforce/libs/io.cdap.plugin.salesforce-plugins-1.6.13.jar/lib/guava-13.0.1.jar

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, exclude the transitive dependency fetched through hydrator-common:2.10.0 and explicitly add the upgraded version.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants