ENH: add deg2rad and rad2deg - #882
Merged
Merged
Conversation
lucascolley
self-requested a review
August 6, 2026 18:29
lucascolley
reviewed
Aug 11, 2026
lucascolley
left a comment
lucascolley
left a comment
Member
There was a problem hiding this comment.
Could you also add test_device methods? See the other test classes for examples.
lucascolley
requested changes
Aug 11, 2026
lucascolley
left a comment
lucascolley
left a comment
Member
There was a problem hiding this comment.
please can we add some simple examples do the docstrings? Then I think this is good to merge!
lucascolley
changed the title
deg2rad and rad2deg
lucascolley
enabled auto-merge (squash)
August 11, 2026 17:33
Member
|
@all-contributors please add @fbourgey for code, tests |
Contributor
|
I've put up a pull request to add @fbourgey! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENH: add
deg2rad#876This a tentative PR adding
deg2radandrad2deg. It appears only JAX accept complex inputs (https://docs.jax.dev/en/latest/_autosummary/jax.numpy.deg2rad.html, https://docs.jax.dev/en/latest/_autosummary/jax.numpy.rad2deg.html)Notes: this is my first PR to
array-api-extraso this might not be the correct approach. I worked with Codex on this, notably on the tests.