Skip to content

Fix build #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix build #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49dcd9b
Fix docs build by set precise dependency constraints to fix pip install
dbalabka Jul 21, 2025
ef48e9f
Add more logging into the test to easily see the issue
dbalabka Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dask_kubernetes/operator/controller/tests/test_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,8 @@ async def test_job(
job_status = _get_job_status(k8s_cluster, ns)
_assert_final_job_status(job, job_status, "Successful")

assert "A DaskJob has been created" in runner.stdout
assert "Job succeeded, deleting Dask cluster." in runner.stdout
assert "A DaskJob has been created" in runner.stdout, f"Can not find proper message in: {runner.stdout}"
assert "Job succeeded, deleting Dask cluster." in runner.stdout, f"Can not find proper message in: {runner.stdout}"


@pytest.mark.anyio
Expand Down Expand Up @@ -718,8 +718,8 @@ async def test_failed_job(
job_status = _get_job_status(k8s_cluster, ns)
_assert_final_job_status(job, job_status, "Failed")

assert "A DaskJob has been created" in runner.stdout
assert "Job failed, deleting Dask cluster." in runner.stdout
assert "A DaskJob has been created" in runner.stdout, f"Can not find proper message in: {runner.stdout}"
assert "Job failed, deleting Dask cluster." in runner.stdout, f"Can not find proper message in: {runner.stdout}"


@pytest.mark.anyio
Expand Down
18 changes: 10 additions & 8 deletions docs/requirements-docs.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
numpydoc
sphinx
# We have to set minimal versions to avoid searches over old versions whose metadata is incompatible with the latest pip
numpydoc<2,>=1.5.0
docutils<0.17,>=0.16
sphinx<5,>=4.0.0
sphinx-reredirects
sphinxcontrib-mermaid
dask-sphinx-theme>=3.0.0
dask-sphinx-theme<4,>=3.0.5
sphinx-helm>=0.2.1

# FIXME: This workaround is required until we have sphinx>=5, as enabled by
# dask-sphinx-theme no longer pinning sphinx-book-theme==0.2.0. This is
# tracked in https://github.com/dask/dask-sphinx-theme/issues/68.
#
sphinxcontrib-applehelp<1.0.5
sphinxcontrib-devhelp<1.0.6
sphinxcontrib-htmlhelp<2.0.5
sphinxcontrib-serializinghtml<1.1.10
sphinxcontrib-qthelp<1.0.7
sphinxcontrib-applehelp<1.0.5,>=1.0.0
sphinxcontrib-devhelp<1.0.6,>=1.0.0
sphinxcontrib-htmlhelp<2.0.5,>=2.0.0
sphinxcontrib-serializinghtml<1.1.10,>=1.0.0
sphinxcontrib-qthelp<1.0.7,>=1.0.0
Loading