Avoid recursing into already substituted expressions #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
We are avoiding the runtime complexity problem with this change but for some queries the substitute operation is still the slowest part. During substitution there are many new objects created (even with #798) so many new |
phofl
approved these changes
Feb 2, 2024
Collaborator
phofl
left a comment
phofl
left a comment
There was a problem hiding this comment.
thx! This is what I meant with caching in the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #835
This should avoid the worst case recursion pattern I described in #835
For the TPCH query this indeed reduces the number of substitute invocations (beyond the guard) from ~13M down to 17k