Provide alternative Bash script#27
Open
JunielKatarn wants to merge 9 commits into
Open
Conversation
Collaborator
We don't want that symlink to be in chroot dir when it is loaded into Docker. Possibly there should be a command-line option whether to create it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in macOS versions 12 and later, paths computed by
otool -Lno longer exist in the raw file system, but are contained in the DYLD cache (i.e./System/Library/dyld).This makes checking every single element being copied into the jail (chroot directory structure) for OTOOL dependencies completely redundant.
The main Python script may not be necessary for the currently supported macOS version range (12-15).
This PR provides the alternative simplified shell script that calls
rsyncdirectly on the known paths to be installed into the jail, including the DYLD cache. The running time benefits can be measured dozens of minutes.Testing
Result: The image ran as expected without issues.
Notes
/var/run/mDNSResponder. Should we add this to the script? What is the risk, based on the commented-out code inmain.py?