Skip to content

[io_file]: Remove --enable-experiment=native-assets flag (now always set) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

[io_file]: Remove --enable-experiment=native-assets flag (now always set) #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/io_file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ on:
paths:
- '.github/workflows/io_file.yml'
- 'pkgs/io_file/**'
- 'pkgs/unix_api/**'
pull_request:
branches: [ main ]
paths:
- '.github/workflows/io_file.yml'
- 'pkgs/io_file/**'
- 'pkgs/unix_api/**'
schedule:
- cron: '0 0 * * 0' # weekly

Expand Down Expand Up @@ -45,7 +47,7 @@ jobs:
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
with:
sdk: ${{ matrix.sdk }}
- run: dart --enable-experiment=native-assets test --reporter=failures-only --test-randomize-ordering-seed=random --platform vm
- run: dart test --reporter=failures-only --test-randomize-ordering-seed=random --platform vm

profile-vm-test:
# Ensure that the tests pass when run under the profiler (which sends
Expand All @@ -56,7 +58,7 @@ jobs:
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
with:
sdk: dev
- run: dart --enable-experiment=native-assets --profiler --profile_period=50 test --reporter=failures-only --test-randomize-ordering-seed=random --platform vm
- run: dart --profiler --profile_period=50 test --reporter=failures-only --test-randomize-ordering-seed=random --platform vm

desktop-vm-benchmark:
strategy:
Expand All @@ -72,9 +74,9 @@ jobs:
sdk: ${{ matrix.sdk }}
- run: dart pub get
- name: 🪑 Run Read Benchmarks
run: dart --enable-experiment=native-assets run benchmarks/read_as_bytes.dart
run: dart run benchmarks/read_as_bytes.dart
- name: 🪑 Run Write Benchmarks
run: dart --enable-experiment=native-assets run benchmarks/write_as_bytes.dart
run: dart run benchmarks/write_as_bytes.dart

android-vm-test:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -129,4 +131,4 @@ jobs:
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
with:
sdk: dev
- run: dart --enable-experiment=native-assets test --reporter=failures-only --test-randomize-ordering-seed=random --platform chrome
- run: dart test --reporter=failures-only --test-randomize-ordering-seed=random --platform chrome
Loading