Replaced the ON CONFLICT DO NOTHING logic with ON CONFLICT DO UPDATE to implement UPSERT #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to implement UPSERT Dynamically use of primary keys for conflict. Only in prepared statement code branch.
Owner
|
Hi @oscarlocatelli, that's a good start. I think that when there's no PK we should search for a unique index and use it. If no PK or unique index are found then DO NOTHING must be used. |
|
Hello, thanks @oscarlocatelli for this PR! I am recently doing a project involving migration from Oracle to PostgreSQL, and the upsert requirements in my project is kinda simple (just needing to use PK to do that), so I wanna ask if this PR are tested before? I want to apply this PR in my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically use of primary keys for conflict.
Only in prepared statement code branch.