Skip to content

Fix crop pixel-precise aligning #19255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crop pixel-precise aligning #19255

wants to merge 1 commit into from
+27 −24

Conversation

jenshannoschwalm
Copy link
Collaborator

@jenshannoschwalm jenshannoschwalm commented Aug 27, 2025 •
edited
Loading

Only the exporting pipes DT_DEV_PIXELPIPE_EXPORT and DT_DEV_PIXELPIPE_THUMBNAIL might want to keep fixed ratios and require pixel-precise size and possibly a slight reposition.

For main and preview pipes this is
a) not required and
b) breaks distort_transform() and distort_backtransform()

Fixes #19135

@jenshannoschwalm jenshannoschwalm added this to the 5.4 milestone Aug 27, 2025
@jenshannoschwalm jenshannoschwalm added bugfix pull request fixing a bug priority: medium core features are degraded in a way that is still mostly usable, software stutters labels Aug 27, 2025
@jenshannoschwalm jenshannoschwalm mentioned this pull request Aug 27, 2025
Open
1 task
@jenshannoschwalm jenshannoschwalm added bug: wip someone is currently working on that, check with them before taking over wip pull request in making, tests and feedback needed labels Aug 27, 2025
@jenshannoschwalm jenshannoschwalm marked this pull request as draft August 27, 2025 10:47
@jenshannoschwalm jenshannoschwalm changed the title Fix crop transform/backtransform Fix crop pixel-precise aligning Aug 28, 2025
@jenshannoschwalm jenshannoschwalm added priority: high core features are broken and not usable at all, software crashes and removed wip pull request in making, tests and feedback needed priority: medium core features are degraded in a way that is still mostly usable, software stutters bug: wip someone is currently working on that, check with them before taking over labels Aug 28, 2025
@jenshannoschwalm jenshannoschwalm marked this pull request as ready for review August 28, 2025 05:03
@jenshannoschwalm
Fix crop pixel-precise aligning
d18d27e 
Only the exporting pipes DT_DEV_PIXELPIPE_EXPORT and DT_DEV_PIXELPIPE_THUMBNAIL might want
to keep fixed ratios and require pixel-precise size and possibly a slight reposition.

For main and preview pipes this is a) not required and b) breaks `distort_transform()` and `distort_backtransform()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

Mask points misaligned when zoomed in while cropping to fixed ratio
1 participant
@jenshannoschwalm