general_enum: Yandex branch should call scrape_yandex, not scrape_bing#515
Open
ChrisJr404 wants to merge 1 commit into
Open
general_enum: Yandex branch should call scrape_yandex, not scrape_bing#515ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
The Yandex branch in general_enum invoked scrape_bing(domain), so selecting -y (or whichever flag enables do_yandex) silently ran a second Bing scrape and labeled the results as Yandex. The Bing branch above and the call site at line 2195 already use scrape_yandex correctly, so this is just a copy-paste bug. Closes darkoperator#505
Contributor
|
Hi @ChrisJr404, just a heads-up — I already have an open PR covering this Yandex scraper fix (along with the dead 'address' guard) at #507. Happy to coordinate or defer if it helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #505.
The Yandex branch in
general_enuminvokedscrape_bing(domain), so selecting-y(or whichever flag enablesdo_yandex) silently ran a second Bing scrape and labeled the results as Yandex. The Bing branch above and the existing call atcli.py:2195already usescrape_yandexcorrectly — this is just a copy-paste from the Bing branch immediately above.Diff
One token change in
dnsrecon/cli.py:Verification