fix(ci): green the flake check by dropping two stale PTY smokes - #4
Merged
Conversation
`nix flake check` has failed on main since 2026-08-12. Three separate causes, each hidden behind the last: 1. checks.nix referenced nix/preflight-hook-pty-test.py and nix/prompt-final-pty-test.py, neither of which was in the tree. Evaluation aborted before building anything, so every check looked broken. 2. The airline PTY smoke asserted that vim-airline REPLACES Prelude's status row — it failed whenever "Run commands:" was on screen, which is the row we actually use. It gated every build on an integration nobody runs. Removed; airline-theme.bash and its wiring still ship, and the static assertions on its faces and import_path still run. 3. The prompt-final smoke asserted the submitted line collapses to Starship's `❯ `. The prompt stopped doing that when it moved to the framed layout and now renders `╰─ : cmd`, so the test failed on a healthy prompt. preflight-hook-pty-test.py is restored rather than dropped: it covers MOTD activation without exported coordination state and passes. 78 checks now build and `nix flake check` exits 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nix flake checkhas failed onmainsince 2026-08-12. Three causes, eachhidden behind the last — which is why fixing one kept revealing another.
1. Two referenced scripts weren't in the tree.
checks.nixcallsnix/preflight-hook-pty-test.pyandnix/prompt-final-pty-test.py; both werecommitted in August and later lost while the references stayed. Evaluation
aborted before building anything, so every check was blocked and the airline
failure was just the first thing anyone saw.
2. The airline smoke gated builds on an integration nobody runs. It asserted
vim-airline replaces Prelude's status row — its failure condition was
literally
"Run commands:" is on screen, which is the row you actually use.Removed.
airline-theme.bashand its wiring still ship, and the staticassertions on its faces and
import_pathstill run, so the parts that could rotsilently are still covered.
3. The prompt-final smoke encodes the old prompt. It asserts the submitted
line collapses to Starship's
❯. The prompt moved to the framed layout and nowrenders
╰─ : cmd, so it failed on a perfectly healthy prompt — visible in itsown screen dump.
preflight-hook-pty-test.pyis restored, not dropped — it covers MOTDactivation without exported coordination state, and it passes.
Result
First green flake check since Aug 12.
🤖 Generated with Claude Code