Skip to content

Fix installer cards would the System Setup onboarding column - #632

Open
Juanpe Bolívar (arximboldi) wants to merge 1 commit into
mainfrom
jp/fix-nix-setup-card-overflow
Open

Fix installer cards would the System Setup onboarding column#632
Juanpe Bolívar (arximboldi) wants to merge 1 commit into
mainfrom
jp/fix-nix-setup-card-overflow

Conversation

@arximboldi

@arximboldi Juanpe Bolívar (arximboldi) commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

An image speaks more than a thousand words.

Before:

Screenshot 2026-08-02 at 09 02 20

After:

Screenshot 2026-08-02 at 11 55 40

Test Plan

  • No test plan needed

Docs

  • Docs updated (companion PR in darkmatter/nixmac-web: #___)
  • No docs update needed

…lumn

The Nix installer cards sat in an auto-sized grid track, which resolves to
the items' max-content width — with `truncate` (whitespace-nowrap) subtitles
that exceeded the step column, so the cards spilled out and the step's scroll
area scrolled horizontally in a narrow window.

Stack them in a flex column instead (a stretched item can't inflate its
container), let the card shrink (`min-w-0`, `shrink-0` on the link icon), and
wrap the subtitles rather than truncating them so no copy is lost at 800px.

The NixSetup story now asserts the step never scrolls horizontally; it fails
on the previous markup.
@darkmatter

darkmatter Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

🎨 Storybook preview

Open Storybook preview

Updated for 2b02558


🧭 Story changes

Compared to main (snapshot diff at story level):

✏️ Changed stories (3)

💡 Update snapshots ↗ to regenerate baselines and open a PR.


⚠️ Detected UI changes (1)

These stories' HTML snapshots changed. I've added screenshots + links to the changed stories below. Review them carefully then accept the changes to regenerate baselines and include them in this PR:

Flows/Evolve › Playground

Flows/Evolve › Playground


Accept UI changes

  • Click here to accept these changes

Alternatively, you can run bun run test:update-snapshots locally to re-generate the baselines and then push the changes to this PR.

What does this do?

The screenshots above show UI changes detected by the Storybook
snapshot tests run on this PR. Each image is the rendered output of
a Storybook story from the code in this PR branch; the snapshot
test compared it against the committed baseline in
__snapshots__/ and flagged the difference.

Checking the box tells the darkmatter[bot] to regenerate the
baselines from this PR's current code and commit them directly to
this branch. The new baselines become the source of truth for
future runs — only accept after confirming the visual changes are
intentional.

Comparison baseline: the committed __snapshots__/ files on this
PR branch (carried forward from develop). Accept updates them in
place on this branch.

@arximboldi Juanpe Bolívar (arximboldi) changed the title fix(onboarding): stop installer cards overflowing the System Setup co… Fix installer cards would the System Setup column Aug 2, 2026
@arximboldi Juanpe Bolívar (arximboldi) changed the title Fix installer cards would the System Setup column Fix installer cards would the System Setup onboarding column Aug 2, 2026
@arximboldi
Juanpe Bolívar (arximboldi) marked this pull request as ready for review August 2, 2026 10:03
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

No Linear issue ID found in this PR's title, description, or branch name (expected something like ENG-123). Add one so this work is traceable in Linear, or add #no-linear to the PR description to acknowledge it's intentionally untracked.

📋 PR Overview

Lines changed 30 (+23 / -7)
Files 0 added, 3 modified, 0 deleted
Draft / WIP no
Has Test Plan no
Linear issue no
No Test Plan Needed yes
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 35.6% 35.3% 30.6% 30.0%

Generated by 🚫 dangerJS against 2b02558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant