fix(drift): glitchy loader, item grouping bug, show hidden error - #630
fix(drift): glitchy loader, item grouping bug, show hidden error#630cooper (czxtm) wants to merge 1 commit into
Conversation
Drift review actions:
- Surface a status message row (Checking…/Building…/Applying…/Check
failed) with a CircleAlert icon for the failed state and a teal
Loader2 spinner when busy.
- Add a shimmer sheen on the Build & Test button while busy so the
disabled state still reads as in-progress.
- Swap the buildButtonLabel computation for a single source of truth.
on diff items, key DriftFileRow by file.hash instead of oldFilename
+ filename — robust against renames showing as separate entries.
chore(review): split up monolith file
🎨 Storybook previewUpdated for 6d8ab4f 🧭 Story changesCompared to 🆕 New stories (1) ✏️ Changed stories (6)
|
📋 PR Overview
🔬 Coverage
|
![prelint[bot]](https://avatars.githubusercontent.com/in/2822344?s=60&v=4){kind=small}
1 participant
Fixes the "Build & Test" button on the drift review page that looks broken due to a missing loader, and not considering the
nix flake checkthat also runsIf
nix flake checkfailed, there was no way to know, now there's an errorSometimes there should be multiple semantic groups but they showed up as one due to a bug, now we key DriftFileRow by file.hash instead of oldFilename + filename — robust against renames showing as separate entries.
refactored that big monolithic component