Fix sortables with jQuery 3 (and Django 3 order of assets) #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery 3 removed the .selector tag, which means that for any modern version of Django the sortable code does not work. Rather than relying on the .selector, this patch follows the recommended jQuery practice of allowing the selector to be passed as an argument. As the suit_list_sortable is not called anywhere except from this function, this fix should be all that is needed.
The Sortables library relies on jQuery being initialised and working before you can load it, otherwise it will error and fail to display. This ensures the correct load order (see https://docs.djangoproject.com/en/3.0/topics/forms/media/#order-of-assets)
|
Docs on the removal of selector… https://api.jquery.com/selector/ |
|
This is a duplicate of #709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses #743 and #744 relating to the sortables patches.