-
Notifications
You must be signed in to change notification settings - Fork 224
Create Dapr WaitStrategy to improve ITs ergonomics #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
|
@dapr/maintainers-java-sdk @dapr/approvers-java-sdk could you please take a look at this PR. It adds a few primitives to Dapr Testcontainers so it is easier and more reliable to add integration tests using Testconainers. @javier-aliaga please also take a look. Thank you! |
…topic. Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
============================================
+ Coverage 76.91% 78.75% +1.84%
- Complexity 1592 2035 +443
============================================
Files 145 225 +80
Lines 4843 6115 +1272
Branches 562 669 +107
============================================
+ Hits 3725 4816 +1091
- Misses 821 958 +137
- Partials 297 341 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Currently we have some very low level way to wait for Dapr container, we are relying on
Wait.forLogMessage(...)it is OK, but it is not Dapr specific and could be brittle. The purpose of this PR is to addDaprWaitthat can wait for Dapr specific components to be up and running.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: