chore: New task execution task id #1430
Open
+225
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javier-aliaga
changed the title
|
@javier-aliaga it seems that there might be some dependency on the Java Durable Task library, currently the build fails with compilation error because |
|
@artur-ciocanu , I put it as draft until the changes are merged |
javier-aliaga
force-pushed
the
task-execution-id
branch
10 times, most recently
from
873f12a to
ee89757
Compare
javier-aliaga
changed the title
javier-aliaga
changed the title
javier-aliaga
force-pushed
the
task-execution-id
branch
from
ee89757 to
a6d9cb0
Compare
* chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]> * chore: Clean up not used files Signed-off-by: Javier Aliaga <[email protected]> * docs: Task execution keys Signed-off-by: Javier Aliaga <[email protected]> * test: Modify unit tests Signed-off-by: Javier Aliaga <[email protected]> * Remove new lines Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
force-pushed
the
task-execution-id
branch
2 times, most recently
from
354fe58 to
9b177cf
Compare
javier-aliaga
force-pushed
the
task-execution-id
branch
from
9b177cf to
030c564
Compare
Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
force-pushed
the
task-execution-id
branch
from
030c564 to
6ec2405
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
============================================
+ Coverage 76.91% 78.73% +1.81%
- Complexity 1592 1919 +327
============================================
Files 145 237 +92
Lines 4843 5925 +1082
Branches 562 610 +48
============================================
+ Hits 3725 4665 +940
- Misses 821 938 +117
- Partials 297 322 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports new task execution id
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: