feat: add config resolution for agent execution config by JeffreyJPZ · Pull Request #642 · dapr/dapr-agents

JeffreyJPZ · 2026-06-12T01:25:30Z

Description

#590 naturally resulted in some refactoring/extra functionality related to agent config resolution that got mixed in with the health endpoints implementation. Since health endpoints is blocked for now I thought I'd open a separate PR for the other stuff.

Add instantiation/environment variable/state store config validation and resolution for AgentExecutionConfig (and AgentObservabilityConfig)
Move config resolution for AgentObservabilityConfig and AgentExecutionConfig out of AgentBase and DurableAgent into their respective classes
Fix bug where max_grpc_inbound_message_size_bytes accepts booleans
Create shared utilities for getting/coercing/validating/transforming/applying config values onto objects
Replace some magic numbers/strings with named constants/enums
Bump mypy to 3.11

Issue reference

Cherry picks some commits from #590

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Created/updated tests
Tested this change against all the quickstarts
Extended the documentation
- Created the dapr/docs PR:

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

TODO:

~~[x] Add unit tests for config helpers~~
~~[x] Add unit tests for agent execution config~~

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 167a29f)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 5772f6a^..a2219d5)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit d5a26f8)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 267e26e^..5a75f7d)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 3d5fbd1)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 5a75f7d)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 40e247f)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 7b841e0)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 7fbe7f5)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 1bd3973)

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

…l choices Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

… config-resolution-refactor

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ · 2026-08-21T03:39:02Z

-    def test_merge_none_values_dont_override(self, mock_llm):
-        """Test that None values in override don't override base values."""


Should be safe to remove since its covered by the config tests

JeffreyJPZ · 2026-08-21T03:39:15Z

-    def test_merge_boolean_fields_correctly(self, mock_llm):
-        """Test that boolean fields merge correctly with None handling."""


Same as above

JeffreyJPZ · 2026-08-21T03:40:00Z

-    def test_merge_empty_configs(self, mock_llm):
-        """Test merging two empty configs."""


This becomes redundant with the refactor

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ · 2026-08-21T18:39:54Z

+                getter=lambda: getenv("DAPR_MAX_GRPC_INBOUND_MESSAGE_SIZE_BYTES"),
+                should_raise=False,
+            ),
+            # TODO: support orchestration_mode from env


Ran into tons of issues trying to support orchestration_mode since None is a valid override, which conflicts with a lot of the existing behaviour. Putting this off for now since runtime config/hot-reloading doesn't support it (yet) which is probably the main benefit.

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ added 30 commits May 27, 2026 11:51

feat: add agent execution config resolution logic

74ff84d

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 167a29f)

refactor: add constants for agent execution defaults

ce8a56a

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 5772f6a^..a2219d5)

fix: merge approval config

9550f30

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit d5a26f8)

fix: change agent execution config priority

42db0e8

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 267e26e^..5a75f7d)

refactor: move agent execution enums to types to avoid circular imports

bff09c6

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 3d5fbd1)

refactor: create process and apply config update methods

aa4947a

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 5a75f7d)

refactor: move config resolution logic out of agent

62ff88c

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 40e247f)

refactor: remove redundant resolution logic

064f9ec

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 7b841e0)

style: lint fixes

2279156

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 7fbe7f5)

style: formatting fix

20d8362

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com> (cherry picked from commit 1bd3973)

fix: cherry pick cleanup

5dc2c2e

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: add fallbacks in merge configs

05d7769

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: add missing classmethod annotation

0fb501d

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

style: format and lint fixes

deee94f

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

test: fix failing observability config tests

eb6c905

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: add header string helper

ce617a1

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: use ConfigFieldDescriptor for observability env config

41ad8c8

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: use ConfigFieldDescriptor for observability statestore config

1e70b00

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: add config key as param to ConfigFieldDescriptor getter

1022c8b

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: fix observability statestore log

32e8f3c

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: use ConfigFieldDescriptor for execution config

d1a5475

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: add apply config map helper

49a481a

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: make config field names the attribute names

c2f0645

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: remove short-circuit for unsupported values

6ca7794

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: return config from config factories

68207b6

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

style: lint fix

9c5c7a9

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

test: make config helper test file

dde0082

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: support bar syntax in config value coercion

c5d94e0

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: remove unused key from getter

ba180d3

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: remove unnecessary validations

7860dca

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ added 13 commits August 18, 2026 17:33

save progress

2d60945

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

chore: access fields from model class

97e5ba4

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

test: add more helper tests

5708960

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

test: fix execution config tests and add test case for permissive too…

ee95079

…l choices Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

feat: validate instantiated execution and observability config

79ac7ab

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

fix: make dapr client config more strict

85d64f4

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

refactor: better separation of responsibilities for config helpers

bde30f8

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

chore: bump mypy to 3.11

b5e9e0a

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

style: lint and formatting fixes

5d4c240

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

chore: document raise/ignore choices

f14f19d

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

Merge branch 'main' of https://github.com/JeffreyJPZ/dapr-agents into…

b9eb664

… config-resolution-refactor

chore: fix execution config field order

27577a3

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

style: lint and formatting fixes

dd1ae9e

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ marked this pull request as ready for review August 21, 2026 03:11

Copilot AI lite review requested due to automatic review settings August 21, 2026 03:11

Copilot AI reviewed Aug 21, 2026

test: remove merge-specific observability config tests

c211230

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ commented Aug 21, 2026

View reviewed changes

JeffreyJPZ marked this pull request as draft August 21, 2026 06:11

JeffreyJPZ added 2 commits August 20, 2026 23:47

test: fix execution config test cases

551bbdf

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

feat: remove orchestration mode from resolution

2fb344e

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ force-pushed the config-resolution-refactor branch from 67aea22 to 2fb344e Compare August 21, 2026 10:40

test: add extra bool field for falsy merge models test

e53204e

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ commented Aug 21, 2026

View reviewed changes

JeffreyJPZ marked this pull request as ready for review August 21, 2026 18:40

JeffreyJPZ marked this pull request as draft August 21, 2026 18:44

JeffreyJPZ force-pushed the config-resolution-refactor branch from f960d85 to f9ae7f5 Compare August 21, 2026 20:34

chore: only include resolvable fields

d69bf16

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

JeffreyJPZ force-pushed the config-resolution-refactor branch from f9ae7f5 to d69bf16 Compare August 21, 2026 21:15

chore: structurally validate non-resolvable fields for execution config

ceb6cd8

Signed-off-by: Jeffrey Zhang <jeffreyjpizhang@gmail.com>

Navigation Menu

Uh oh!

feat: add config resolution for agent execution config - #642

feat: add config resolution for agent execution config#642
JeffreyJPZ wants to merge 59 commits into
dapr:mainfrom
JeffreyJPZ:config-resolution-refactor

JeffreyJPZ commented Jun 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

JeffreyJPZ Aug 21, 2026

Uh oh!

JeffreyJPZ Aug 21, 2026

Uh oh!

JeffreyJPZ Aug 21, 2026

Uh oh!

JeffreyJPZ Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		def test_merge_none_values_dont_override(self, mock_llm):
		"""Test that None values in override don't override base values."""

		def test_merge_boolean_fields_correctly(self, mock_llm):
		"""Test that boolean fields merge correctly with None handling."""

		def test_merge_empty_configs(self, mock_llm):
		"""Test merging two empty configs."""

Uh oh!

Conversation

JeffreyJPZ commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

JeffreyJPZ Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

JeffreyJPZ Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

JeffreyJPZ Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

JeffreyJPZ Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JeffreyJPZ commented Jun 12, 2026 •

edited

Loading