Address performance issues with _check_disallowed_items overhead#176
Merged
Conversation
Downstream in meltano/sdk#3565 (comment), we noticed a performance regression in the 1.0.5 release of `simpleeval`. The root problem seems to be that 1. there too many redundant instance checks for safe primitive types 2. `is_hashable` has try/except overhead. The fix is for 1 is to implement a fast path for simple types. The fix for 2 is to replace `is_hashable` with [`callable`](https://docs.python.org/3/library/functions.html#callable), which achieves the same purpose in this context. Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
danthedeckie
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR doing?
Downstream in meltano/sdk#3565 (comment), we noticed a performance regression in the 1.0.5 release of
simpleeval.The root problem seems to be that
is_hashablehas try/except overhead.The fix is for 1 is to implement a fast path for simple types. The fix for 2 is to replace
is_hashablewithcallable, which achieves the same purpose in this context.Benchmark script
Details
Before
After
Script:
Pre-approval checklist (for submitter)
Please complete these steps