feat(agent-chat): move Show settings to per-machine browser state#292
Open
danshapiro wants to merge 4 commits intomainfrom
Open
feat(agent-chat): move Show settings to per-machine browser state#292danshapiro wants to merge 4 commits intomainfrom
danshapiro wants to merge 4 commits intomainfrom
Conversation
added 4 commits
April 7, 2026 09:34
…ser state Show thinking, Show tools, and Show timecodes were stored per-pane in AgentChatPaneContent. They now live in LocalSettings (browser-local localStorage), shared across all agent chat panes and persisted across page loads. All three default to off (false).
… settings E2e tests now use preloadedState with showTools: true where expanded tools are expected. CollapsedTurn defaults updated to false. Comments updated to reflect new per-machine defaults.
Migrate showThinking/showTools/showTimecodes from persisted agent-chat pane content into browser-local preferences on module load, so existing users keep their settings after the per-pane → per-machine move.
- SettingsView.agent-chat.test.tsx: 9 tests for Workspace toggles (defaults, preloaded state, toggle on/off, local-only persistence) - browserPreferencesPersistence.test.ts: 4 round-trip tests for agentChat.showThinking/showTools/showTimecodes localStorage persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
maindrift into a dedicated PR branchTesting
npm run test:vitest -- test/unit/shared/settings.test.ts test/unit/client/store/state-edge-cases.test.ts test/unit/client/store/panesPersistence.test.ts test/unit/client/store/browserPreferencesPersistence.test.ts test/unit/client/components/SettingsView.agent-chat.test.tsxnpm run test:vitest -- test/unit/client/components/agent-chat/AgentChatView.behavior.test.tsx test/unit/client/components/agent-chat/AgentChatView.perf-audit.test.tsx test/unit/client/components/agent-chat/MessageBubble.test.tsx test/unit/client/components/agent-chat/ToolStrip.test.tsx test/e2e/agent-chat-context-menu-flow.test.tsx test/e2e/agent-chat-polish-flow.test.tsx