Fix README paper link + ignore .DS_Store files (Closes #191)#192
Open
naivoder wants to merge 3 commits intodanijar:mainfrom
Open
Fix README paper link + ignore .DS_Store files (Closes #191)#192naivoder wants to merge 3 commits intodanijar:mainfrom
naivoder wants to merge 3 commits intodanijar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes two minor but important fixes:
Replaces the outdated direct PDF link to the DreamerV3 paper with a link to the arXiv landing page (https://arxiv.org/abs/2301.04104).
The previously linked PDF pointed to an earlier version of the paper.
That version used a different set of hyperparameters which radically changes the implementation and may mislead users.
Linking to the arXiv abstract page ensures readers always see the latest version.
Adds .DS_Store to .gitignore to avoid polluting the repo with macOS metadata files.
Changes
README.md:
Old: https://arxiv.org/pdf/2301.04104.pdf
New: https://arxiv.org/abs/2301.04104
.gitignore:
Added .DS_Store
Rationale
This improves usability and avoids confusion, especially for those attempting to replicate or build on DreamerV3. Also a small quality-of-life fix for devs on macOS.
Closes #191