Fix issue with the decompressor truncating the output in some cases.#3
Open
spencercw wants to merge 1 commit intodanielrh:masterfrom
Open
Fix issue with the decompressor truncating the output in some cases.#3spencercw wants to merge 1 commit intodanielrh:masterfrom
spencercw wants to merge 1 commit intodanielrh:masterfrom
Conversation
If the source reader returns EOF along with the final data block, instead of returning EOF on the read *after* the final block then that EOF was getting passed through to the caller immediately. If there was still decompressed data that hadn't been read yet then this would result in the decompressed output being truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the source reader returns EOF along with the final data block, instead of returning EOF on the read after the final block then that EOF was getting passed through to the caller immediately. If there was still decompressed data that hadn't been read yet then this would result in the decompressed output being truncated.